ocaml-multicore / multicoretests

PBT testsuite and libraries for testing multicore OCaml
https://ocaml-multicore.github.io/multicoretests/
BSD 2-Clause "Simplified" License
37 stars 16 forks source link

Merge Cygwin CI workflow parts #420

Closed jmid closed 10 months ago

jmid commented 10 months ago

This PR merges the two GitHub actions workflow parts for Cygwin into a single one.

Initially, the split was done out of necessity in https://github.com/ocaml-multicore/multicoretests/pull/305 and https://github.com/ocaml-multicore/multicoretests/pull/313 as the Cygwin port initially was too slow to complete within the 6h timeout!

Since then we have seen general OCaml (GC) improvements, meaning that the 2-part Cygwin CI workflow would complete in about 2x45m, and thus opening up for a workflow merge incl. saving time on storing and restoring the state.

Finally I offer two data points from a trial run of this branch:

jmid commented 10 months ago

Cygwin-wise, the 4 merged workflows completed 69m, 76m, 79m, and 84m, thus confirming that merging should be OK. We may even consider lowering the time out at some point...

With the removal of the bytes dependency in qcheck-core.0.21.3 we had a record low 12m run on Linux testing 5.1 - and 12 complete GA runs of <=20m! :tada:

CI summary:

Out of 59 workflows 4 failed with 3 genuine issues and 1 CI issue.

shym commented 10 months ago

I updated the PR according to my suggestion :-)

jmid commented 10 months ago

Of the 3 Cygwin runs 3 completed in 80m, 87m, 127m and 1 timed out after 6h because of a deadlock.

CI summary:

Out of 59 workflows 13 failed, with 10 triggering genuine errors, 1 false alarm, and 2 internal CI failures

jmid commented 10 months ago

CI summary for merge to main:

Out of 36 workflows 5 failed with 3 genuine issues and 2 CI setup-related failures