Revert temporary acceptance in STM Out_channel test

ocaml-multicore / multicoretests

PBT testsuite and libraries for testing multicore OCaml

BSD 2-Clause "Simplified" License

37 stars 16 forks source link

Closed jmid closed 7 months ago

jmid commented 7 months ago

The PR

reverts the temporary acceptance of Ok on output to a closed Out_channel from 86f2ab27 in #431 as this has now been fixed in https://github.com/ocaml/ocaml/pull/12678
marks the issue as fixed in the issues list

Finally I snuck in adding the Cygwin flexlink issue, to avoid having that trigger a full CI run...

jmid commented 7 months ago

This was opened too soon, causing all 5.2 workflows to fail as they were still testing 5.2.0~alpha1 without the fix.

Now that CI targets 5.2.0~beta1 with #445 I've rebased the PR.

In doing so I've removed the commit marking the Out_channel issue as fixed, as that was fixed in #442.

jmid commented 7 months ago

CI summary:

Out of 37 workflows 4 failed, all with genuine issues

jmid commented 7 months ago

CI summary for merge to main:

Out of 38 workflows 4 failed, all with genuine issues