ocaml-multicore / multicoretests

PBT testsuite and libraries for testing multicore OCaml
https://ocaml-multicore.github.io/multicoretests/
BSD 2-Clause "Simplified" License
37 stars 16 forks source link

Naming inconsistency between Lin and QCheck #450

Closed OlivierNicole closed 4 months ago

OlivierNicole commented 5 months ago

Lin uses the name nat_small, whereas QCheck2 uses small_nat, which is a bit unfortunate. Same for int_small.

jmid commented 5 months ago

Ack. This is an old pain point: c-cube/qcheck#223, c-cube/qcheck#243, and c-cube/qcheck#245 are attempts to normalize the situation to use consistent prefix names int*, nat*, string*, bytes*, ... for the various generators. Anticipating this change, for Lin we thus went with the normalized names from the beginning. Now, I need to get back to normalize the "upstream" qcheck names...

OlivierNicole commented 5 months ago

I see, thanks! Please feel free to close since this is already being addressed.

jmid commented 4 months ago

OK, I'll close then as the (long-term) intention is to offer renamed generators in qcheck, making the naming more consistent and predictable across the board.