ocaml-multicore / multicoretests

PBT testsuite and libraries for testing multicore OCaml
https://ocaml-multicore.github.io/multicoretests/
BSD 2-Clause "Simplified" License
37 stars 16 forks source link

Reenable Bigarray STM tests #452

Closed jmid closed 6 months ago

jmid commented 6 months ago

This PR reenables the Bigarray STM tests, the idea being that a model-based STM test is stricter than a Lin one.

A bit of background:

jmid commented 6 months ago

The two 32-bit runs are failing since size_in_bytes return 4b * 16 = 64b and breaks with the 8b word assumption hardcoded in the mode. I guess #250 predates us testing 32-bit... :shrug:

On macOS 5.2 and MSVC bytecode the parallel STM Bigarray tests failed to trigger a counterexample within 1000 iterations. The old Lin test had a count of 5000 for this reason.

CI summary for 4713ced:

jmid commented 6 months ago

Rebased on main after the merge of #453 to remove noise.

jmid commented 6 months ago

CI summary:

This one was missed in #453 - #454 addresses the omission

Out of 37 workflows 1 failed with a genuine issue

jmid commented 6 months ago

CI summary for merge to main:

Out of 38 workflows 1 failed with a genuine issue