search

ocaml-omake / omake

The new home of OMake - docs, downloads, mailing list etc. see:
http://projects.camlcity.org/projects/omake.html
GNU General Public License v2.0
67 stars 25 forks source link

clean-ups for OCaml-5 #153

Closed gerdstolpmann closed 1 year ago

gerdstolpmann commented 2 years ago

Closes #152

jhwoodyatt commented 2 years ago

The opam file in the project root doesn't pass the lint checks.

jhwoodyatt commented 2 years ago

Also, the current branch is incompatible with the proposed effect syntax, which will introduce the effect keyword, the pervasively visible functions perform, continue and discontinue and the eff type constructor. OCaml 5.0 does not include this proposed syntax yet (the effects support is "experimental" and available only via the low-level Effects library in the distribution).

Do the OMake maintainers want to prepare for that proposed syntax now? I can prepare a pull request with the appropriate revisions. I can't say it's strictly necessary to do it for the OCaml 5.0 release.

jhwoodyatt commented 2 years ago

Otherwise: 👍🏽 (it exposes some errors in my Conjury 2.1 library for OMake, because OCaml 5.0 moves some libraries around in the distribution).