search

ocaml-opam / opam-0install-solver

a solver for opam packages using 0install's solver engine
ISC License
21 stars 13 forks source link

Allow "Unknown variable" warnings to be surpressed #49

Closed gridbugs closed 1 year ago

gridbugs commented 1 year ago

When using the opam-0install library to solve dependencies the "Unknown variable" warnings can get in the way of other console output. This adds an optional argument which enables printing this warning (defaulting to true).

kit-ty-kate commented 1 year ago

What kind of unknown variable issue are you having? Is that related to https://github.com/ocaml-opam/opam-0install-solver/pull/46 ?

gridbugs commented 1 year ago

It's adding a lot of noise to the output of opam monorepo lock which looks like https://github.com/tarides/opam-monorepo/issues/349 and https://github.com/ocaml-opam/opam-0install-solver/issues/45.

kit-ty-kate commented 1 year ago

In that case it's an actual bug (variables that should be taken into account are not) so I would be inclined to close this and instead to focus on fixing https://github.com/tarides/opam-monorepo/issues/349 properly. Do you want to have a go at it?

cc @Leonidas-from-XIV

Leonidas-from-XIV commented 1 year ago

I mean, #46 already exists and solves this issue, just needs to get approved or revised and merged.

gridbugs commented 1 year ago

Ah I didn't realize there was already a fix for this in progress. Happy to close this and focus on the existing fix instead.