Treat opensuse-leap as opensuse in os-distribution

ocaml-opam / opam-depext

Attempt to automate the installation of system packages required by OPAM packages

Other

33 stars 28 forks source link

Treat opensuse-leap as opensuse in os-distribution #110

Closed yutopp closed 5 years ago

yutopp commented 5 years ago

Resolve #109.

Outputs:

opam@4846b79c61c0:/opam> cat /etc/os-release 
NAME="openSUSE Leap"
VERSION="15.0"
ID="opensuse-leap"
ID_LIKE="suse opensuse"
VERSION_ID="15.0"
PRETTY_NAME="openSUSE Leap 15.0"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:opensuse:leap:15.0"
BUG_REPORT_URL="https://bugs.opensuse.org"
HOME_URL="https://www.opensuse.org/"
opam@4846b79c61c0:/opam> ./opam-depext 
# Detecting depexts using flags: x86_64 linux opensuse

yutopp commented 5 years ago

Sorry, I think that it is not an issue of opam-depext.

avsm commented 5 years ago

Why is this not a opam-depext issue? The fix looks correct to me.

AltGr commented 5 years ago

OS detection is now done directly by opam, opam-depext being limited to choosing the proper package installation instructions.

yutopp commented 5 years ago

Thank you for your reply!

OS detection is now done directly by opam

Yes, I realized that the published version of opam-depext on opam is based on 2.0 branch and there are no code base related to the patch in this PR. :sob: It uses opam var os-distribution which is a feature provided by opam to get an environment name, thus there is no function to determine the value of os-distribution now in opam-depext.

Thanks.