search

ocaml-opam / opam-depext

Attempt to automate the installation of system packages required by OPAM packages
Other
33 stars 28 forks source link

Fix shell quotes #132

Closed kit-ty-kate closed 4 years ago

kit-ty-kate commented 4 years ago

This PR fixes the following issue:

$ opam depext 'odoc>1.5.0'
# Detecting depexts using vars: arch=x86_64, os=linux, os-distribution=debian, os-family=debian
# No extra OS packages requirements found.
# All required OS packages found.
$ ls
1.5.0

Would it be possible to have a urgent fix release for this? This makes opam depext a potential very harmful command (can overwrite users files :cry:). @rjbou @AltGr

kit-ty-kate commented 4 years ago

@dra27 I believe my last commit takes care of your comment. I used Filename.quote instead of Filename.quote_command as, even if the patch would be better it complicates the diff more (would require to change the way every commands are created), and I'm not sure it's worth the effort.