search

ocaml-opam / opam-depext

Attempt to automate the installation of system packages required by OPAM packages
Other
33 stars 28 forks source link

Check current opam version using a proper comparaison function #89

Closed kit-ty-kate closed 6 years ago

kit-ty-kate commented 6 years ago

In the current version the check is failing with opam 2.0.0~rc This PR takes the version comparison function(s) from opam/dose and uses it.

avsm commented 6 years ago

This embeds a different license into depext ...

avsm commented 6 years ago

Not only do we not have the mentioned exception in our LICENSE file, we do not have a LICENSE file at all :-)

kit-ty-kate commented 6 years ago

opam seems to point to "LGPL-3.0 with OCaml linking exception" to it looks like it's the same license or I'm missing something ?

avsm commented 6 years ago

The version number of the licenses is entirely different.

kit-ty-kate commented 6 years ago

ah. I see :/

avsm commented 6 years ago

Depext should really have the same license as opam, which is lgpl 2.1+exception. It may be a good time to do this for 2.0

kit-ty-kate commented 6 years ago

I did a PR if this helps: https://github.com/ocaml/opam-depext/pull/90

AltGr commented 6 years ago

Thanks! Importing the whole generic comparison module seems a bit overkill to me, though, esp. considering that we know the format of the version we're comparing in advance, and this was a one-file project.

AltGr commented 6 years ago

"LGPL-3.0 with OCaml linking exception" is the broken, invalid license we had been moving away from (because the "exception" in question was defined against 2.1 and doesn't in fact apply to 3.0). So yes, this was waiting to be fixed, thanks.

avsm commented 6 years ago

Importing the whole generic comparison module seems a bit overkill to me

If it had been imported from the start, we wouldn't have broken opam2 containers now :-) It seems ok to leave it in here to be a bit more resistant to future changes. It would be good to have it separately as a standalone module at some point, but for now this lgtm.

AltGr commented 6 years ago

Well, we never import that function to check OCaml versions... this gives me the same feeling.

Thanks a lot for finding the error and providing as solution so quickly!