search

ocaml-ppx / ocaml-migrate-parsetree

DEPRECATED. See https://ocaml.org/changelog/2023-10-23-omp-deprecation. Convert OCaml parsetrees between different major versions
Other
87 stars 43 forks source link

Support 4.12 #107

Closed ceastlund closed 3 years ago

ceastlund commented 3 years ago

Added support for 4.12 compiler to ocaml-migrate-parsetree. Updated instructions in README for adding new versions.

NathanReb commented 3 years ago

Following #106 we'll need to upgrade the upper bound!

hhugo commented 3 years ago

The build fails with old version of the compiler

characters 9-19:
# Error: Unbound module Option
NathanReb commented 3 years ago

Hmm actually it seems this breaks the compat with ocaml < 4.07, see the CI failure:

File "src/migrate_411_412.ml", line 1194, characters 20-42:
Error: Unbound module Stdlib
Hint: Did you mean Stdlib0?
ceastlund commented 3 years ago

Hmm actually it seems this breaks the compat with ocaml < 4.07, see the CI failure:

File "src/migrate_411_412.ml", line 1194, characters 20-42:
Error: Unbound module Stdlib
Hint: Did you mean Stdlib0?

I don't get this error with, say, 4.04 currently. It should be fixed as of 058ff45. What compiler version and what git revision are you using that still gets that error?

ceastlund commented 3 years ago

We need to upgrade the constraint in the opam file from < "4.12" to < "4.13" but besides that it looks good to me!

@ceastlund can you confirm once the constraint is updated this is good to go? I'd like to cut a release ASAP!

As far as I know this is good to go, but of course I've missed things other people had to point out. If it looks good to you now, it also looks good to me.

NathanReb commented 3 years ago

I don't get this error with, say, 4.04 currently. It should be fixed as of 058ff45. What compiler version and what git revision are you using that still gets that error?

That was in the CI but it's fixed now!