ocaml-ppx / ocaml-migrate-parsetree

DEPRECATED. See https://ocaml.org/changelog/2023-10-23-omp-deprecation. Convert OCaml parsetrees between different major versions
Other
87 stars 43 forks source link

Improve the instructions in the README to add a new version of the OCaml compiler #113

Closed kit-ty-kate closed 2 years ago

kit-ty-kate commented 3 years ago

~The instructions did not explicitly said that expression,pattern,core_type,toplevel_phrase needed to be changed and I kept getting weird failures when running gencopy.exe. Thanks to @pitag-ha for realizing that it should be replaced by the types that changed between the two versions.~

~Hopefully the wording is clear enough with that.~

EDIT: Mmh, nevermind.

kit-ty-kate commented 3 years ago

I also found an issue when using zsh. According to the documentation (https://zsh.sourceforge.io/Doc/zsh_a4.pdf): scrn-2021-05-28-20-24-53

kit-ty-kate commented 3 years ago

Merging https://github.com/ocaml-ppx/ocaml-migrate-parsetree/pull/115 first should fix CI