search

ocaml-ppx / ocaml-migrate-parsetree

DEPRECATED. See https://ocaml.org/changelog/2023-10-23-omp-deprecation. Convert OCaml parsetrees between different major versions
Other
87 stars 43 forks source link

Fix handling of `--impl/--intf` #43

Closed ghost closed 6 years ago

ghost commented 6 years ago

Currently, if the extension of the filename passed as argument of --impl or --intf is neither .ml nor .mli, the driver fails with the following error:

 Error: I can't decide whether parser__mock.ml.mock is an implementation or interface file

This PR adds a regression test and fixes the issue.

let-def commented 6 years ago

This looks nice, thanks :)

let-def commented 6 years ago

Do you want to make a release soon?

ghost commented 6 years ago

Yep, we need this for the new menhir rules which should be in the next release of Dune,

fpottier commented 6 years ago

I will soon make a PR with the new Menhir rules.

ghost commented 6 years ago

Cool, I'm preparing a minor release of omp.

ghost commented 6 years ago

https://github.com/ocaml/opam-repository/pull/12123