search

ocaml-ppx / ocaml-migrate-parsetree

DEPRECATED. See https://ocaml.org/changelog/2023-10-23-omp-deprecation. Convert OCaml parsetrees between different major versions
Other
87 stars 43 forks source link

Make ocamlbuild_plugin optional #56

Closed nojb closed 5 years ago

nojb commented 5 years ago

This one-liner simply makes the building of ocamlbuild_plugin optional, which allows to vendor ocaml-migrate-parsetree without ocamlbuild.

rgrinberg commented 5 years ago

Isn't it already in a separate package? If you don't depend on ocamlbuild_plugin, it shouldn't introduce issues when vendoring.

nojb commented 5 years ago

Not sure why, but it does, regardless of whether you depend on it or not... I will give it a closer look tomorrow and report back here.

nojb commented 5 years ago

Why do you say it is a separate package?

rgrinberg commented 5 years ago

It's in this package, isn't it? https://github.com/ocaml-ppx/ocaml-migrate-parsetree/blob/master/ocaml-migrate-parsetree-ocamlbuild.opam

ghost commented 5 years ago

I suppose the issue is that when you vendor it, then the @install alias picks up both packages.

nojb commented 5 years ago

Yes, I just arrived at the same conclusion.

nojb commented 5 years ago

What would be the best way to handle this?

ghost commented 5 years ago

@rgrinberg has a proposal for explicitly marking the vendored directory: https://github.com/ocaml/dune/issues/1016. The idea would be that aliases such as @install wouldn't pick up things in the vendor directory: only what's needed from the vendor directory would be built.

nojb commented 5 years ago

Sounds reasonable, so closing this one. Thanks!