search

ocaml-ppx / ocaml-migrate-parsetree

DEPRECATED. See https://ocaml.org/changelog/2023-10-23-omp-deprecation. Convert OCaml parsetrees between different major versions
Other
87 stars 43 forks source link

[wip] 4.08 omp parsetree #65

Closed avsm closed 5 years ago

avsm commented 5 years ago

I took a quick look at adding 4.08 support, and ran into a question: where does gencopy come from? The ppx_tools repository has no such tool, and genlifter appears to be something else.

This PR currently just has a snapshot of ast_NEW.ml for 4.08 and some minor README instruction fixes

hhugo commented 5 years ago

@avsm, are you aware of https://github.com/ocaml-ppx/ocaml-migrate-parsetree/issues/50 and https://github.com/hhugo/ocaml-migrate-parsetree/tree/408

avsm commented 5 years ago

nope i missed that, thanks! This was just a quick go for me to learn how omp works, so happy to close my PR. Could I get an answer to the gencopy question though? I'd like to submit the README fixes to the instructions

let-def commented 5 years ago

gencopy can be found in copy_parsetree branch: https://github.com/ocaml-ppx/ppx_tools/tree/copy_parsetree

avsm commented 5 years ago

I'll close this as the bulk of effort is likely shifting to ppxlib in the future...