--dump-ast: preserve binary AST version

ocaml-ppx / ocaml-migrate-parsetree

DEPRECATED. See https://ocaml.org/changelog/2023-10-23-omp-deprecation. Convert OCaml parsetrees between different major versions

Other

87 stars 43 forks source link

--dump-ast: preserve binary AST version #81

Closed aantron closed 4 years ago

aantron commented 5 years ago

Resolves #79.

aantron commented 5 years ago

There will probably be a merge conflict if also merging #80. When I get an email about merging the first PR, I'll be happy to resolve any conflict in the other PR and rebase.

ghost commented 5 years ago

Looks good. Did you test this change?

aantron commented 5 years ago

Yes, I tested manually, and it's continuously tested in Bisect_ppx's CI, where OMP (and Bisect_ppx) is built with OCaml 4.08, and is processing BuckleScript's 4.02 ASTs, which the 4.02 BuckleScript is accepting. I previously also had CI installing BuckleScript 6.x, which is using 4.06 ASTs, and that worked, too.

aantron commented 5 years ago

After all the PRs are in, I'll check the resulting master again, so we can be more sure before any release.