ocaml-ppx / ocaml-migrate-parsetree

DEPRECATED. See https://ocaml.org/changelog/2023-10-23-omp-deprecation. Convert OCaml parsetrees between different major versions
Other
87 stars 43 forks source link

Add ?argv argument to Driver.run_main #82

Closed aantron closed 5 years ago

aantron commented 5 years ago

The context is that Bisect_ppx needs to translate a command line issued by bsb into a different command line for the OMP driver (with Bisect_ppx linked in).

Until recently, Bisect_ppx master used a wrapper binary for this. The wrapper binary did the translation, found the Bisect_ppx OMP driver, and then called exec. This is fragile, because it depends on reconstructing paths. It is also annoying to maintain, if distributing precompiled binaries.

So, it seems better to link Bisect_ppx and OMP directly into the wrapper, and have the wrapper act as the final driver executable.

ghost commented 5 years ago

Looks good, thanks