ocaml-ppx / ocaml-migrate-parsetree

DEPRECATED. See https://ocaml.org/changelog/2023-10-23-omp-deprecation. Convert OCaml parsetrees between different major versions
Other
87 stars 43 forks source link

support for upcoming OCaml 4.10 ? #85

Closed gasche closed 4 years ago

gasche commented 4 years ago

As of this week, the versions of ocaml-migrate-parsetree available on opam are incompatible (or at least marked incompatible) with the upcoming 4.10 release. Would it be possible to ensure compatibility with the current 4.10 branch, and have a version available on opam that enables it, or at least a clear reference to pin? This would unlock testing of user code when we make our first beta releases (expected in a few weeks).

(We do not expect to change the parsetree now that the release branch has been created, but there is a small chance that it could happen, for example thanks to m-o-p dogfooding the changes and suggesting fixes. I still think having an opam release is nicer than pinning, especially for people doing release Q/A with opam testing tools.)

Thanks!

gasche commented 4 years ago

(cc @Octachron @damiendoligez @kit-ty-kate)

ghost commented 4 years ago

Let me have a look at this. What's the recommended way of installing a non-released compiler nowadays?

gasche commented 4 years ago

It's documented in the compiler's HACKING.adoc file:

opam switch create . --empty
opam install .
ghost commented 4 years ago

The magic numbers for the AST ends with 26 in 4.09 and with 25 in 4.10. That looks ood

gasche commented 4 years ago

It may be very well be that the magic numbers have not been updated in 4.10 yet. Let me check with @damiendoligez, thanks for the feedback!

gasche commented 4 years ago

Yes! @Octachron volunteered to update magic numbers in 4.10 and trunk, should be done shortly.

Octachron commented 4 years ago

The magic numbers have updated (and end with 27), on both 4.10 and trunk (to avoid trunk trailing with the magic number of 4.08).

ghost commented 4 years ago

I updated ocaml-migrate-parsetree to 4.10. Release is pending on this: https://github.com/samoht/dune-release/issues/174

ghost commented 4 years ago

it's now released: https://github.com/ocaml/opam-repository/pull/15280