failures in ppx_deriving after upgrade from 1.5.0 to 1.6.0

ocaml-ppx / ocaml-migrate-parsetree

DEPRECATED. See https://ocaml.org/changelog/2023-10-23-omp-deprecation. Convert OCaml parsetrees between different major versions

Other

87 stars 43 forks source link

failures in ppx_deriving after upgrade from 1.5.0 to 1.6.0 #90

Closed olafhering closed 4 years ago

olafhering commented 4 years ago

ocaml-migrate-parsetree was upgraded from v1.5.0 to v1.6.0. All packages which depend on this package were rebuilt automatically. For some reason ocaml-ppx_deriving now fails to build. It runs ppxfind -legacy, which is now "suddenly" an unknown cmdline option.

I reverted back to v1.5.0 get the prj devel:languages:ocaml back into state succeeded. The build log of ppx_deriving indicates ppxfind -legacy is working, Not sure how migrate-parsetree influences the behavior of ppx_deriving

aantron commented 4 years ago

@olafhering See https://github.com/ocaml/opam-repository/pull/15821 and all the linked PRs, including https://github.com/ocaml/opam-repository/pull/15830 and https://github.com/diml/ppxfind/pull/6. OMP 1.6.0 broke ppxfind (unexpectedly, at least for me), so the new release 1.4 of ppxfind is required to work with it.

olafhering commented 4 years ago

Yes, I have seen the new ppxfind package, it fixed the build error.