search

ocaml-ppx / ocaml-migrate-parsetree

DEPRECATED. See https://ocaml.org/changelog/2023-10-23-omp-deprecation. Convert OCaml parsetrees between different major versions
Other
87 stars 43 forks source link

Another fix for #97: `Ast_4NN.register` reads and writes current AST #99

Closed thierry-martinez closed 4 years ago

thierry-martinez commented 4 years ago

As @gasche explained in https://github.com/ocaml-ppx/ocaml-migrate-parsetree/issues/97#issuecomment-632660967, there is two possible semantics for Ast_4NN.register.

(1) register a 4NN-rewriter in such a way that it works on current serialized ASTs

(2) register a 4NN-rewriter in such a way that it works on serialized ASTs for OCaml 4NN

This pull-request implements (1) whereas https://github.com/ocaml-ppx/ocaml-migrate-parsetree/pull/98 implements (2).

ghost commented 4 years ago

As mentioned in #98, I'm going to remote these register functions.