search

ocaml-ppx / ppx_deriving

Type-driven code generation for OCaml
MIT License
466 stars 89 forks source link

Update ppx_deriving.cppo.mli #268

Open marrious11 opened 1 year ago

marrious11 commented 1 year ago

Added a deprecation signature to https://github.com/ocaml-ppx/ppx_deriving/edit/master/src/api/ppx_deriving.cppo.mli#L48. Sir @panglesd, please let me know if the modifications I am doing is not right. Though, I find it difficult to locate the exact lines of code to modify as supposed to https://github.com/roddyyaga/ppx_rapper/issues/29. Signed-off-by: Mario 66856309+marrious11@users.noreply.github.com

panglesd commented 1 year ago

Hello @marrious11!

Though, I find it difficult to locate the exact lines of code to modify as supposed to https://github.com/roddyyaga/ppx_rapper/issues/29.

I'll help you on this in the issue thread! (actually, by email)

This repository is the one of a different project, ppx_deriving, which contains useful derivers, as well as several helpers to write your own deriver. However, currently the recommended way to register derivers has been to use ppxlib, hence the discussion whether to deprecate some of ppx_deriving API in #263.

However, deprecating (or not) ppx_deriving API is not really related to https://github.com/roddyyaga/ppx_rapper/issues/29!

marrious11 commented 1 year ago

😞 alright sir @panglesd. Thank you for the redirect