search

ocaml-ppx / ppx_deriving_yojson

A Yojson codec generator for OCaml.
MIT License
155 stars 46 forks source link

Add support for OCaml 4.10 #112

Closed kit-ty-kate closed 4 years ago

kit-ty-kate commented 4 years ago

This adds support for OCaml 4.10.

Relies on https://github.com/ocaml-ppx/ppx_deriving/pull/211 and https://github.com/ocaml-ppx/ppx_tools/pull/79

kit-ty-kate commented 4 years ago

CI is all green and ppx_deriving.4.4.1 was just released. This is good to merged. cc @gasche

gasche commented 4 years ago

I think that the factorization choice is weird: rather than turning mknoloc name into mod_mknoloc name, I would rather turn it into mknoloc (mod_name name), because the change is related to name representation and independent of the mknoloc operation.

On the other hand, we had a discussion about this on a previous PR, and I prefer to merge the version that you battle-tested than making changes at the last minute. (We wouldn't need to have this discussion if I had reviewed those changes promptly; apologies for the delay on my side.)

Thanks!