search

ocaml-ppx / ppx_deriving_yojson

A Yojson codec generator for OCaml.
MIT License
157 stars 46 forks source link

Fails to build on OCaml 4.11 because Pconst_string added an extra Loc.t parameter #116

Closed rwmjones closed 4 years ago

rwmjones commented 4 years ago 
+ dune build -j48
File "ppx_deriving_yojson.cppo.ml", line 388, characters 39-72:
Error: The constructor Pconst_string expects 3 argument(s),
       but is applied here to 2 argument(s)
rwmjones commented 4 years ago

This is the downstream patch I have applied to work around this: https://src.fedoraproject.org/rpms/ocaml-ppx-deriving-yojson/blob/master/f/ocaml-411.patch

XVilka commented 4 years ago

Will be solved by https://github.com/ocaml-ppx/ppx_deriving_yojson/pull/118

XVilka commented 4 years ago

Should be closed, I think because of https://github.com/ocaml-ppx/ppx_deriving_yojson/commit/d06711479564486554aa0834fe900ac27d55ccc4 cc @thierry-martinez @gasche

gasche commented 4 years ago

Thanks for the triaging help, I will close indeed.