search

ocaml-ppx / ppx_deriving_yojson

A Yojson codec generator for OCaml.
MIT License
155 stars 46 forks source link

Tentative lightning OCaml 4.11.0 support #122

Closed thierry-martinez closed 4 years ago

thierry-martinez commented 4 years ago

This pull-request is supposed to work with https://github.com/ocaml-ppx/ppx_deriving/pull/222/commits/592a9dff07dd919481a0e677029aacb9a0dfd890

The purpose is to be able to make a minor release (both for ppx_deriving and its rev-dependencies) with just OCaml 4.11.0 support before making the major ppxlib release.

gasche commented 4 years ago

This looks good to me, assuming the CI is happy. It would be nice to have a pre-ppxlib branch here as well.

thierry-martinez commented 4 years ago

It is all green now. Would a maintainer like to create a pre-ppxlib branch and merge this pull-request into? Many thanks!

gasche commented 4 years ago

Done.