search

ocaml-ppx / ppx_import

Less redundancy in type declarations and signatures
MIT License
89 stars 29 forks source link

Add note about ppx_deriving and dune in README #33

Closed andreas closed 5 years ago

andreas commented 5 years ago

I imagine using ppx_import together with ppx_deriving and Dune is a fairly common use case, so I propose adding a note about this to the README.

ejgallego commented 5 years ago

There already is a section "combining with deriving", maybe it would look better there?

andreas commented 5 years ago

There already is a section "combining with deriving", maybe it would look better there?

My initial intent with the section was to document use with Dune, since I imagine the same approach is required for use with ppxlib. I wasn't sure though, so made it specific to ppx_deriving. I don't mind the section being in either position.

ejgallego commented 5 years ago

Well indeed it may be OK in that position, thanks! I've left a non-binding comment in case you would like to further tweak the README, otherwise I'll merge tomorrow as to allow time for other contributors to comment if they wish.