search

ocaml-ppx / ppx_import

Less redundancy in type declarations and signatures
MIT License
89 stars 28 forks source link

Upgrade from Ast_407 to Ast_411 #52

Closed gasche closed 3 years ago

gasche commented 3 years ago

Fixes #50.

I was a bit surprised by how easy the change was: I had a couple things to change from 407 to 408, and then all following updates were no-ops. (cd src && sed -i "s/408/409/g" *.* dune, and that's it) The testsuite still passes, and the example from #50 is now correctly parsed.

gasche commented 3 years ago

( cc @ejgallego )

ejgallego commented 3 years ago

( cc @ejgallego )

Thanks @gasche , seems fine to me, glad it worked out easy; I did some local testing and things do work fine. It seems we have a problem with the travis setup tho.

gasche commented 3 years ago

I fixed the name of the 4.11 switch in the travis file, let's wait to check that everything works as intended.

Would you be able to take care of a new release with the change?

ejgallego commented 3 years ago

I fixed the name of the 4.11 switch in the travis file, let's wait to check that everything works as intended.

Thanks, seems to work fine.

Would you be able to take care of a new release with the change?

Sure, that makes me wonder if a) we need a changes entry [I prefer so] b) do we need to bump some of the deps.

I will take of checking b) myself before the release.

gasche commented 3 years ago

Good point, I added a changes entry.