search

ocaml-ppx / ppx_include

Include OCaml source files in each other
MIT License
10 stars 4 forks source link

Clarify compatibility with dune? #3

Open tomjridge opened 5 years ago

tomjridge commented 5 years ago

I guess this package is not compatible with dune? Are there any plans to make it compatible?

Leandros commented 5 years ago

I'm wondering, too. I'm getting 

Error: Uninterpreted extension 'include'.
Leandros commented 5 years ago

I have updated it, to work with dune and ocaml-migrate-parsetree: https://github.com/aexpl/ppx_include Take a look at the test for usage with dune, and even other derivers.

I've also published it in my personal OPAM repo, if you want to use it: https://github.com/aexpl/opam-repository

tomjridge commented 5 years ago

Good work! Thanks!

On Thu, 18 Apr 2019 at 13:49, Arvid Gerstmann notifications@github.com wrote:

I have updated it, to work with dune and ocaml-migrate-parsetree: https://github.com/aexpl/ppx_include

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ocaml-ppx/ppx_include/issues/3#issuecomment-484492536, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKKSV7ORIZBL7J5ERKJLULPRBU4BANCNFSM4HF6O77Q .

tomjridge commented 5 years ago

And now I have looked at the examples, everything works fine! Thank you very much @Leandros

Leandros commented 5 years ago

You're welcome. I've also fixed a bug which prevented anything after an [%%include ...] to be parsed. It can now be used in almost all places correctly. As well as reporting the correct filename in errors.