search

ocaml-ppx / ppx_tools

Tools for authors of ppx rewriters
MIT License
134 stars 39 forks source link

The ast mapper should explicitly specify the mapping order. #27

Closed hhugo closed 3 years ago

hhugo commented 9 years ago

ie:

    | Ptyp_arrow (lab, t1, t2) ->
        arrow ~loc ~attrs lab (sub # typ t1) (sub # typ t2)

should be written 

    | Ptyp_arrow (lab, t1, t2) ->
        let t1' = sub # typ t1 in
        let t2' = sub # typ t2 in
        arrow ~loc ~attrs lab t1' t2'