search

ocaml-ppx / ppx_tools

Tools for authors of ppx rewriters
MIT License
134 stars 39 forks source link

Broken on 4.02 branch #4

Closed whitequark closed 10 years ago

whitequark commented 10 years ago 
ocamlc -w +A-4-17-44-45 -I +compiler-libs -safe-string -c ast_lifter.ml
File "ast_lifter.ml", line 44, characters 18-21:
Error: Syntax error: operator expected.

Seems to be a bug in Pprintast, but I may be wrong.

whitequark commented 10 years ago

@alainfrisch Can you please take a look? It breaks all my current work on the latest trunk & I don't really understand what the problem is, to fix it myself.

xorpse commented 10 years ago

The problem seems to be introduced by this commit: ocaml/ocaml@9fa17c9; it causes the pretty printer to omit parenthesis when pretty-printing funs. By cloning trunk and removing the changes, ppx_tools compiles fine for me.

whitequark commented 10 years ago

@gasche When do you think you could revert https://github.com/ocaml/ocaml/commit/9fa17c9 ?

alainfrisch commented 10 years ago

@whitequark I'm just back from vacations. Thanks for your investigation. I'll let @gasche look at it.

gasche commented 10 years ago

I just looked at it and it's indeed a bug I introduced; fill fix as soon as possible (not during my working hours today).

alainfrisch commented 10 years ago

I've committed a fix to the 4.02 branch (commit 14946) and to OCaml trunk (commit 14947).