search

ocaml-ppx / ppx_tools

Tools for authors of ppx rewriters
MIT License
134 stars 39 forks source link

4.08 support #69

Closed copy closed 5 years ago

copy commented 5 years ago

On a 4.08.0+beta1 switch:

File "ast_convenience.ml", line 1:
Error: The implementation ast_convenience.ml
       does not match the interface ast_convenience.cmi:
       Values do not match:
         val has_attr : 'a -> ('a Location.loc * 'b) list -> bool
       is not included in
         val has_attr : string -> Parsetree.attributes -> bool
       File "ast_convenience.mli", line 108, characters 0-42:
         Expected declaration
       File "ast_convenience.ml", line 121, characters 4-12:
         Actual declaration
jhwoodyatt commented 5 years ago

I believe this is addressed by #70.

copy commented 5 years ago

The master branch installs fine on 4.08. Closing.