ocaml-ppx / ppx_tools

Tools for authors of ppx rewriters
MIT License
134 stars 39 forks source link

ppx_metaquot broken with ocaml 4.08 #75

Closed hhugo closed 5 years ago

hhugo commented 5 years ago

I believe metaquot is currently broken on 4.08. One should ignore pexp_loc_stack, ptyp_loc_stack, ppat_loc_stack when generating patterns on the ast. see what's done for location and attributes: https://github.com/ocaml-ppx/ppx_tools/blob/master/ppx_metaquot.ml#L175

Also see the patch in ppx_tools_versionned https://github.com/ocaml-ppx/ppx_tools_versioned/pull/22/files#diff-7ab097557bb7183454f885e4595acc38R180