search

ocaml-ppx / ppxlib

Base library and tools for ppx rewriters
MIT License
244 stars 94 forks source link

Make `Context_free.map_top_down`'s `embed_errors` arg optional #468

Closed NathanReb closed 5 months ago

NathanReb commented 5 months ago

This extra argument that was added in #453 caused breakage in ocsigen-i18n that was using Context_free.map_top_down.

Although it's undocumented, this function is still part of the public API. Adding an extra optional argument is not strictly speaking non-breaking but is good enough of an effort considering the status of this function and in particular, the fact that it only has a single public external user at the moment, for which it does prevent breakage.

NathanReb commented 5 months ago

I added a changelog entry in case it does introduce breakage outside opam-repo somewhere, to help users track it down to the next release!