search

ocaml-semver / ocaml-api-watch

Libraries and tools to keep watch on you OCaml lib's API changes
ISC License
21 stars 15 forks source link

Detect addition and removal of class type declarations #103

Closed azzsal closed 17 hours ago

azzsal commented 1 week ago

This aims to fix #83. Sorry about the delay.

There is a bit of code duplication with class declarations code. I will fix that, if you have an approach in mind, please let me know.

As with class declarations, a type is added when a class type declaration is added. Also a class type is added when a class declaration is added. This could be a bit confusing for a user of our tool/library. I think that should be fixed, but maybe by a different issue/PR.

NathanReb commented 4 days ago

Thanks for the contribution @azzsal and sorry for the delay, I'll try to review it today!

azzsal commented 1 day ago

@NathanReb

I will open an issue later today to fix that. Thanks!