search

ocaml-semver / ocaml-api-watch

Libraries and tools to keep watch on you OCaml lib's API changes
ISC License
21 stars 15 forks source link

Added initial implementation of diff_interface #43

Closed Siddhi-agg closed 5 months ago

Siddhi-agg commented 6 months ago

This PR fixes #41.

Siddhi-agg commented 6 months ago

@NathanReb I have coded an initial implementation for diffing value changes, but some of the test cases aren't successful with this implementation. The cases when types are added, removed and modified and the case where value is removed show that val f has been modified along with the expected result. I have tried to tweak the logic for modification of values to compare the type_desc of the type_expr, but that doesn't seem to work as well. I think the problem may lie in the id fields used in the type_desc but I can't figure it out yet.