search

ocaml-semver / ocaml-api-watch

Libraries and tools to keep watch on you OCaml lib's API changes
ISC License
21 stars 15 forks source link

Add support for module types #93

Closed NchamJosephMuam closed 1 month ago

NchamJosephMuam commented 1 month ago

@NathanReb @panglesd This PR closes #81

NchamJosephMuam commented 1 month ago

@panglesd Thank you for the reviews.

NchamJosephMuam commented 1 month ago

Hi @panglesd @NathanReb I tried to make some updates based on the reviews you left. Sorry it takes some time. I am still learning OCaml and I am happy to be learning more during this contribution phase.

Is there something I can add to this PR to make it better? I've tried to refactor the code as much as possible to reduce duplication. I've also filtered out the test to remove a lot of noise and just test specific things I've tried to represent diff changes for all the common scenarios (I don't know if this is going in the direction you envision)

NchamJosephMuam commented 1 month ago

@NathanReb @panglesd Is there something I can add to the PR to get it ready for a merge?