Closed AltGr closed 11 months ago
Hi @AltGr, thanks for working on this!
Unfortunately you merged the PR very quickly before it was tagged with Close #575
.
Do you know why the gh-pages
branch is not created?
AFAIAC, I'm not familiar with actions/deploy-pages@v3
,
I had used peaceiris/actions-gh-pages@v3
instead,
but actions/deploy-pages@v3
looks more "official"...?
gh-pages
branch is the "old style" way of publishing, now it's purely handled by a Github action IIUC. That was already the way https://ocaml-sf.org/learn-ocaml/ was generated by the way, so I had to extend it to add https://ocaml-sf.org/learn-ocaml/artifacts
Unfortunately you merged the PR very quickly before it was tagged with Close #575.
Technically speaking the PR wasn't enough to solve the issue, I had to experiment with a few patches before I got it working... And GH provides no way that I could find to test on non-master branches
(anyway changelogs are for the actual app, and this doesn't affect it in any way ?)
@AltGr, ah okay, thank you! I hadn't realized the website was already up at URL https://ocaml-sf.org/learn-ocaml/artifacts/ Thanks a lot for this nice work!
Technically speaking the PR wasn't enough to solve the issue, I had to experiment with a few patches before I got it working... And GH provides no way that I could find to test on non-master branches
Yes you're right, no worries!
(anyway changelogs are for the actual app, and this doesn't affect it in any way ?)
Yes: on the one hand it is not a direct feature of the app,
but on the other hand, it is some ci
feature that'll be very useful to users, certainly worth it to document in release notes
like we had done previously:
Anyway, no worries at all! it is always possible to edit releases notes slightly before we merge the release PR.
Close #575