search

ocaml-sys / config.ml

conditional compilation via attributes for OCaml
Other
27 stars 4 forks source link

Tidy up eval_attr by extracting the expression #10

Closed gpetiot closed 8 months ago

gpetiot commented 8 months ago

This removes the string manipulation, by relying on printing a smaller part of the code.

On the flip side we now rely on the way the attributes are encoded as a Pstr_eval in the payload, but I don't see that changing in the near future.

leostera commented 8 months ago

Thanks @gpetiot for the PR! Looks great :) Just left the comment back in, and merging now.