Open glennsl opened 2 years ago
Hm sorry about this, I have not updated this template for some time. I will try to take a look soon.
In the meantime, as a workaround I can suggest checking https://github.com/ml-in-barcelona/jsoo-react-template, which does not have the convenience of this spin template, but has been updated quite recently.
Thanks, will give that a shot!
Also, if it helps, it fails with 4.08 too, but with a slightly different error:
#=== ERROR while compiling gen_js_api.1.0.6 ===================================#
# context 2.1.1 | linux/x86_64 | ocaml-base-compiler.4.08.1 | pinned(git+https://github.com/jchavarri/gen_js_api.git#typ_var#1e629a51)
# path ~/.opam/4.08.1/.opam-switch/build/gen_js_api.1.0.6
# command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p gen_js_api -j 4
# exit-code 1
# env-file ~/.opam/log/gen_js_api-2355154-c3b56c.env
# output-file ~/.opam/log/gen_js_api-2355154-c3b56c.out
### output ###
# ocamlc ppx-driver/.gen_js_api_ppx_driver.objs/byte/gen_js_api_ppx_driver.{cmi,cmo,cmt} (exit 2)
# (cd _build/default && /home/glennsl/.opam/4.08.1/bin/ocamlc.opt -w -40 -g -bin-annot -I ppx-driver/.gen_js_api_ppx_driver.objs/byte -I /home/glennsl/.opam/4.08.1/lib/base -I /home/glennsl/.opam/4.08.1/lib/base/base_internalhash_types -I /home/glennsl/.opam/4.08.1/lib/base/caml -I /home/glennsl/.opam/4.08.1/lib/base/shadow_stdlib -I /home/glennsl/.opam/4.08.1/lib/ocaml-compiler-libs/common -I [...]
# File "ppx-driver/gen_js_api_ppx_driver.ml", line 22, characters 4-39:
# 22 | Ppxlib.Driver.enable_location_check ()
# ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: Unbound value Ppxlib.Driver.enable_location_check
I checked the template and it seems it was created at a time where we had to pin gen_js_api
to a custom fork.
That's not the case anymore, as jsoo-react
uses the published version of gen_js_api. So I don't think we need to pin gen_js_api
like the spin template is doing here:
This fails during
spin new
with error:Running
make dev
yields:Looking at the
Makefile
suggests this was made for OCaml 4.10, but switching to that yields the same error:cc @jchavarri as this is what
jsoo-react
suggests for getting started.