Closed Emm closed 9 years ago
:+1: :+1: Really good news! :+1: :+1:
Some comments about coding style.
I did not deeply checked the code, but it looks good to me. Nothing seems broken, which is the most important anyway :-)
Thank you for this.
:santa: That's the chrismas spirit ! :gift: under the :christmas_tree: :)
Code looks good :+1: LGTM, and thank you for the PR.
While we're at it... What should we do with the Dumper module? Currently, it's useless, because it operates on internal types, but we use the abstract types in our tests. I think we should keep doing that (it's a good way to detect design issues in the API), but it also means we don't have a pretty-printer for our tests, and it makes debugging more painful than necessary. That said, we could expose it, which would give us back our pretty-printer, and it may be useful for end-users as well. It does break encapsulation, but no sane user would rely on parsing strings returned by a pretty-printer.
The Christmas pull request. Array of tables for the people.