Closed Emm closed 9 years ago
:+1:
For the next PR, could you push you branch (here v2_doc
) on this repo, then create the PR from mackwic:v2_doc
to mackwic:master
, so that anyone can clone the mackwic:v2_doc
branch and push on it to contribute ?
I would like to add some details on the Changelog but it's not easy when the PR is done directly from the forked repo.
git ckeckout -b feature-my-branch
git push origin feature-my-branch
git push mackwic feature-my-branch
Sorry for this change in the workflow, but PR are really tough when they reference a foreign branch.
All things considered, it's a :+1: for me. Though, I would have liked some more details on the Changelog about what's different between 1.0 and 2.0, and I also would add moar @since
. :)
Meh. It can wait another PR another time. I don't have much time right now so my planning is rather happy that I can't open-procrastinate on PRs.
Aaaand, I did it again. I continued the work on PR #28 on a branch we can all push on. I close this PR as it's the same commits.
Add @since and changelog.
I think we're ready for 2.2.0 with this!