search

ocaml-toml / To.ml

OCaml library for TOML
https://ocaml-toml.github.io/To.ml
Other
82 stars 20 forks source link

V2 doc #27

Closed Emm closed 9 years ago

Emm commented 9 years ago

Add @since and changelog.

I think we're ready for 2.2.0 with this!

coveralls commented 9 years ago

Coverage Status

Coverage remained the same when pulling 787a3ecb8a7311644127a8b994835898dc437e43 on Emm:v2_doc into 3a2ba78051f754be0eb5a48339cda88f24d22d73 on mackwic:master.

sagotch commented 9 years ago

:+1:

mackwic commented 9 years ago

For the next PR, could you push you branch (here v2_doc) on this repo, then create the PR from mackwic:v2_doc to mackwic:master, so that anyone can clone the mackwic:v2_doc branch and push on it to contribute ?

I would like to add some details on the Changelog but it's not easy when the PR is done directly from the forked repo.

Summary:

  1. git ckeckout -b feature-my-branch
  2. code & commit & sync with git push origin feature-my-branch
  3. When ready: git push mackwic feature-my-branch
  4. Go on this repo's url and create the PR directly.

Sorry for this change in the workflow, but PR are really tough when they reference a foreign branch.

mackwic commented 9 years ago

All things considered, it's a :+1: for me. Though, I would have liked some more details on the Changelog about what's different between 1.0 and 2.0, and I also would add moar @since. :)

Meh. It can wait another PR another time. I don't have much time right now so my planning is rather happy that I can't open-procrastinate on PRs.

mackwic commented 9 years ago

Aaaand, I did it again. I continued the work on PR #28 on a branch we can all push on. I close this PR as it's the same commits.