search

ocaml-toml / To.ml

OCaml library for TOML
https://ocaml-toml.github.io/To.ml
Other
82 stars 20 forks source link

Fails to build on 4.06.0 #47

Closed ghost closed 6 years ago

ghost commented 6 years ago 
File "src/tomlUnicode.ml", line 13, characters 4-93:
Warning 3: deprecated: String.set
Use Bytes.set instead.
File "src/tomlUnicode.ml", line 14, characters 26-27:
Error: This expression has type bytes but an expression was expected of type
         string
# opam-version 1.2.2
# os           linux
# command      make build
# path         /home/x/.opam/4.06.0/build/toml.4.0.0
# compiler     4.06.0
# exit-code    2
# env-file     /home/x/.opam/4.06.0/build/toml.4.0.0/toml-7096-541cda.env
# stdout-file  /home/x/.opam/4.06.0/build/toml.4.0.0/toml-7096-541cda.out
# stderr-file  /home/x/.opam/4.06.0/build/toml.4.0.0/toml-7096-541cda.err
### stdout ###
# [...]
# Error: This expression has type bytes but an expression was expected of type
#          string
# Command exited with code 2.
# + ocamlfind ocamlopt unix.cmxa -I /home/x/.opam/4.06.0/lib/ocamlbuild /home/x/.opam/4.06.0/lib/ocamlbuild/ocamlbuildlib.cmxa -linkpkg myocamlbuild.ml /home/x/.opam/4.06.0/lib/ocamlbuild/ocamlbuild.cmx
-o myocamlbuild
# File "myocamlbuild.ml", line 518, characters 43-62:
# Warning 3: deprecated: Ocamlbuild_plugin.String.uncapitalize
# Use String.uncapitalize_ascii instead.
# File "myocamlbuild.ml", line 531, characters 51-70:
# Warning 3: deprecated: Ocamlbuild_plugin.String.uncapitalize
# Use String.uncapitalize_ascii instead.
### stderr ###
# [...]
# Warning 3: deprecated: String.uncapitalize
# Use String.uncapitalize_ascii instead.
# File "setup.ml", line 5847, characters 11-28:
# Warning 3: deprecated: String.capitalize
# Use String.capitalize_ascii instead.
# File "setup.ml", line 5848, characters 11-30:
# Warning 3: deprecated: String.uncapitalize
# Use String.uncapitalize_ascii instead.
# E: Failure("Command ''/home/x/.opam/4.06.0/bin/ocamlbuild' src/toml.cma src/toml.cmxa src/toml.a src/toml.cmxs -use-ocamlfind -tag debug' terminated with error code 10")
# make: *** [Makefile:7: build] Error 1
ghost commented 6 years ago

This fixes it: https://github.com/mackwic/To.ml/pull/49

mackwic commented 6 years ago

Wow ! Thank you for the Issue and the fix. This is great work :)

The PR has been merged, we can close this issue.