ocaml-toml / To.ml

OCaml library for TOML
https://ocaml-toml.github.io/To.ml
Other
82 stars 20 forks source link

Inconsistent signature of TomlTypes.Table in v5.0.0 #59

Closed gersonmoraes closed 3 years ago

gersonmoraes commented 5 years ago

Hi there,

There is a problem with the documentation for version v5.0.0 - it lies at least 10 times. The problem is the signature of TomlTypes.Table, generated with the Stdlib's Map.Make that has changed many times since OCaml 4.02. Since there's not a *.mli file, the incompatibility is only noticed when you try to access the API. Below there's a list of functions from Map.S (the result of Map.Make) and whey they were introduced:

Since 4.03.0

Since 4.05.0:

Since 4.06.0:

zapashcanon commented 3 years ago

I bumped the minimal OCaml version to 4.07, so it isn't lying anymore except on filter_map which was added in OCaml 4.11. That's good enough so I'm closing.