ocaml / Zarith

The Zarith library implements arithmetic and logical operations over arbitrary-precision integers and rational numbers. The implementation, based on GMP, is very efficient.
Other
231 stars 70 forks source link

Remove source preprocessing and simplify configuration #94

Closed xavierleroy closed 3 years ago

xavierleroy commented 3 years ago

This PR is a "reboot" of #86 and #87.

Now that per-target asm files are gone and OCaml 4.04 is the minimal version supported, we can remove a number of configuration parameters and avoid the preprocessing of z.mli and z.ml.

The version number can also be handled without preprocessing, as shown in #87.

antoinemine commented 3 years ago

Thanks!

configure still has some leftover code we could remove for asm configuration and flags (-noasm, -host, asopt, ASFLAGS).

In project.make, grep '^version' assumes a specific indentation of the META file (there are two version lines, only one of them has no space before). A grep 'version' | head -1 could fix this (nitpick).

xavierleroy commented 3 years ago

Right, thanks for the quick feedback. I pushed two commits that implement your suggestions.

antoinemine commented 3 years ago

I think we could merge this. Unless you see further simplifications?

xavierleroy commented 3 years ago

OK, merging now!