search

ocaml / dune

A composable build system for OCaml.
https://dune.build/
MIT License
1.63k stars 404 forks source link

3.15.1 release tracking #10427

Closed emillon closed 6 months ago

emillon commented 6 months ago

Preparation

anmonteiro commented 6 months ago

as reported in https://github.com/ocaml/opam-repository/pull/25690#issuecomment-2063046712, 3.15.1 breaks ocaml-protoc-plugin.

The offending set of changes seems to be https://github.com/ocaml/dune/pull/10432 / #10382. I reverted that change in the 3.15 branch and the cycle disappeared.

jonahbeckford commented 6 months ago
emillon commented 6 months ago

So there's indeed a regression on ocaml-protoc-plugin, including the last version. It looks like we were ignoring the cycle before, and now it's causing an issue. I filed #10447 for this but it any case that can't be fixed in a patch release so I'll cut 3.15.2 without it.

@jonahbeckford 3.15.1 has already been tagged, but your input is valuable for 3.15.2 which I'll prepare today. Let me know if you have any feedback about it.

emillon commented 6 months ago

(amending what I said above, the fix will be to backport #10442)

Leonidas-from-XIV commented 6 months ago

However, given 3.15.1 is not merged, I think we should close that PR and replace it with 3.15.2.

emillon commented 6 months ago

yes, I'll do that when the changelog etc have been merged

jonahbeckford commented 6 months ago

Thanks. I have long test cycles so I'm stuck testing Dune 3.15.0 for the time being. And since I haven't found any Windows blockers (yet) I'll probably ship DkML 2.1.1 with Dune 3.15.0.

I don't have the resources to increase the cadence, so (in hindsight) it is better just keeping with the status quo.

emillon commented 6 months ago

OK, thanks. Note that 3.15.1 includes a fix for gcc 4.8.5.