Installing developer preview didn't set up PATH correctly on zsh

edwintorok commented 1 month ago

Expected Behavior

$ dune --version
"Dune Developer Preview: build 2024-09-28T01:30:13+00:00, git revision
17071ec30d10390badcb6cb1f6a43984b1be54a6"
$ echo $PATH
/var/home/edwin/.dune/bin:/var/home/edwin/.opam/5.2.0+fp/bin:/var/home/edwin/.cargo/bin:/var/home/edwin/.local/bin:/var/home/edwin/.dune/bin:/var/home/edwin/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/sbin:/var/home/edwin/.dotnet/tools

Actual Behavior

$ dune --version
3.16.0
$ zsh -l
$ echo $PATH
/var/home/edwin/.opam/5.2.0+fp/bin:/var/home/edwin/.cargo/bin:/var/home/edwin/.local/bin:/var/home/edwin/.nix-profile/bin:/var/home/edwin/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/sbin:/var/home/edwin/.dotnet/tools
$ zsh
$ echo $PATH
/var/home/edwin/.opam/5.2.0+fp/bin:/var/home/edwin/.cargo/bin:/var/home/edwin/.local/bin:/var/home/edwin/.nix-profile/bin:/var/home/edwin/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/sbin:/var/home/edwin/.dotnet/tools

Reproduction

You can find my full ZSH config here: https://gitlab.com/edwintorok/dotfiles/-/tree/master/zsh?ref_type=heads

However for the purposes of this bug you can repro it with:

PR with a reproducing test:

opam install dune
echo 'return 0' >.zshrc
curl https://dune.ci.dev/install | bash 1.zsh -l
dune --version
echo $PATH

Specifications

Version of dune (output of dune --version): 3.16.0
Version of ocaml (output of ocamlc --version): 5.2.0
Operating system (distribution and version): Fedora 40

Additional information

Dune added this to my .zshrc, but that has no effect

# dune
export PATH="/var/home/edwin/.dune/bin:$PATH"

If I instead I add it to .zshenv it is better, but still in the wrong place (opam takes precedence):

/var/home/edwin/.opam/5.2.0+fp/bin:/var/home/edwin/.dune/bin:/var/home/edwin/.cargo/bin:/var/home/edwin/.local/bin:/var/home/edwin/.nix-profile/bin:/var/home/edwin/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/sbin:/var/home/edwin/.dotnet/tools

The reason it doesn't work in .zshrc because mine ends like this:

# Setup highlighting {{{
# Must be last according to its docs
ZSH_HIGHLIGHT_HIGHLIGHTERS=(main brackets)
#SYNTAX=/usr/share/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh
SYNTAX=~/dotfiles/zsh/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh
[[ -s ${SYNTAX} ]] && . ${SYNTAX}
return 0

So I need to move the export PATH before the 'return 0', so this works:

export PATH="/var/home/edwin/.dune/bin:$PATH"

# Setup highlighting {{{
# Must be last according to its docs
ZSH_HIGHLIGHT_HIGHLIGHTERS=(main brackets)
#SYNTAX=/usr/share/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh
SYNTAX=~/dotfiles/zsh/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh
[[ -s ${SYNTAX} ]] && . ${SYNTAX}
return 0

edwintorok commented 1 month ago

It might be difficult to automatically modify the user's PATH (there could be a lot of other things than return 0 that could prevent the last line from being executed), but one improvement the dune installer could do is to verify whether the PATH modification worked, and if it didn't ask the user to check that the script didn't exit early.

One way to test that is: zsh -i -c 'echo $PATH'

And then check that the newly installed dune is really the first one found in that PATH (and e.g. that opam or something else didn't override it)

(note the -i for interactive shell, if you just do zsh -l -c 'echo $PATH' or zsh -c 'echo $PATH', then it wouldn't work without also modifying .zshenv).

maiste commented 1 month ago

As this issue is related to the distribution of the preview version of dune and not about dune itself, I move it to https://github.com/ocaml-dune/binary-distribution. @edwintorok I have reposted your question here: https://github.com/ocaml-dune/binary-distribution/issues/85.

ocaml / dune