fix: patch expect tests on macos

ocaml / dune

A composable build system for OCaml.

https://dune.build/

MIT License

1.64k stars 409 forks source link

fix: patch expect tests on macos #11132

Closed gridbugs closed 4 days ago

gridbugs commented 1 week ago

A recent update to macos's patch command broke some of our tests. The relevant changes to the command's behaviour are that it's stricter about line numbers in patch metadata, and it no longer deletes files, truncating them instead. This updates dune's patch expect tests to accomodate this behaviour.

Leonidas-from-XIV commented 4 days ago

Looks like github rolled back the CI runner to use macos 14.7, hence the tests succeed again at the moment but I expect everyone who tries to run them on 15.1 will have the same failures, so I'm merging it for future-proofing.