ocaml / dune

A composable build system for OCaml.
https://dune.build/
MIT License
1.63k stars 401 forks source link

dune upgrade: include jbuild.inc fails #1815

Closed avsm closed 5 years ago

avsm commented 5 years ago

Continuing the dune upgrade on a duniverse, camomile also fails.

File "ocaml_modules/camomile/Camomile/charmaps/dune", line 22, characters 0-20:
22 | (include jbuild.inc)
     ^^^^^^^^^^^^^^^^^^^^
Error: File ocaml_modules/camomile/Camomile/charmaps/jbuild.inc doesn't exist.
$ more ocaml_modules/camomile/Camomile/charmaps/
broken/        dune           dune.inc       dups/          jbuild_gen.ml  .merlin        sources/       
$ cat ocaml_modules/camomile/Camomile/charmaps/dune
(rule
 (deps
  (glob_files sources/*))
 (targets jbuild.inc.gen)
 (action
  (with-stdout-to
   %{targets}
   (run ocaml %{dep:jbuild_gen.ml} sources))))

(copy_files sources/*)

(alias
 (name jbuild)
 (action
  (diff jbuild.inc jbuild.inc.gen)))

(alias
 (name runtest)
 (deps
  (alias jbuild)))

(include jbuild.inc)

Looks like something changed regarding include semantics from jbuild -> dune

ghost commented 5 years ago

Oh... We do upgrade the included files, however we don't update the filename inside the (include ...) stanza :see_no_evil: