search

ocaml / dune

A composable build system for OCaml.
https://dune.build/
MIT License
1.63k stars 409 forks source link

dune install ignores --for-release-of-packages #2757

Open olafhering opened 5 years ago

olafhering commented 5 years ago

The build, runtest, external-lib-deps and maybe other commands recognize the comma separated list of packages in the --for-release-of-packages knob. But the install command seems to ignore that knob. Instead, it requires a space separated list of packages.

Is this intentional?

For rpm package build I would like to use a consistent set of options, like for qcheck:

pkgs='qcheck,qcheck-core,qcheck-ounit'
dune external-lib-deps --for-release-of-packages=${pkgs} @install
dune external-lib-deps --for-release-of-packages=${pkgs} @runtest
dune build --for-release-of-packages=${pkgs} @install
dune install --for-release-of-packages=${pkgs}
dune runtest --for-release-of-packages=${pkgs}

However, the install command requires an extra ${pkgs//,/ }.

ghost commented 5 years ago

We probably didn't think of this use case. dune install is a bit different in the sense that it doesn't build anything, but supporting this seems fine to me.

rgrinberg commented 2 years ago

@bobot what do you think about this?