MDX stanza not causing dependencies to be built - Githubissues

ocaml / dune

A composable build system for OCaml.

https://dune.build/

MIT License

1.63k stars 404 forks source link

MDX stanza not causing dependencies to be built #4971

Open Leonidas-from-XIV opened 3 years ago

Leonidas-from-XIV commented 3 years ago

Expected Behavior

When (using mdx 0.1) the files listed in the mdx stanza should be checked for existance and if they can't be generated an error should be raised.

Actual Behavior

The mdx stanza ignores all missing files and doesn't try to build or execute them.

Reproduction

PR with a reproducing test: #4973, otherwise:

Clone https://github.com/Leonidas-from-XIV/mdx-rule-test
dune runtest
Test succeed, despite the test files missing

Specifications

Version of dune (output of dune --version): 2.9.1
Version of ocaml (output of ocamlc --version)
Operating system (distribution and version): Fedora Linux 34

Additional information

Link to gist with verbose output (run dune with the --verbose flag):

voodoos commented 2 years ago

We discussed this in the dev meeting. Current behaviour of globs is that they can silently match nothing and this is not a bug. We concluded that it would be awkward to have only some glob fields warn if they are empty and not others.

The next step is to write an RFC on how we could improve the situation for all glob files.