ocaml / dune

A composable build system for OCaml.
https://dune.build/
MIT License
1.63k stars 409 forks source link

[coq] [coq-lang-1.0] Ensure test suite is comprehensive. #7598

Open ejgallego opened 1 year ago

ejgallego commented 1 year ago

Before (coq lang 1.0) we need to ensure that we are testing all possible configurations of Coq Dune projects.

It seems there are quite a few, let's study the variables:

That's a lot of combos to test, but can be reduced with a bit of care.

Another point to consider is how to have a naming scheme that help us identify what part of the test matrix the test is covering.

Alizter commented 1 year ago

Regarding the naming, if we separate tests by directories then that won't be too much of a problem.

ejgallego commented 1 year ago

Regarding the naming, if we separate tests by directories then that won't be too much of a problem.

How would such directories be named? What I mean by naming scheme is a directory / test name that allows us to understand what variables on the matrix are covered.

palmskog commented 1 year ago

Some use cases we have in Coq-community and I have myself:

palmskog commented 1 year ago

I think we can add the use case where I discovered #8042:

Specifically, in Chapar, there are three different key-value store executables produced from three different Coq modules. However, those executables share the same OCaml infrastructure/libraries, so it makes sense for them to be defined in the same dune file.

ejgallego commented 1 year ago

Yes @palmskog , we would like to fix #8042