Open glondu opened 1 year ago
In "reproducible release mode" (-p or --release), Dune should not change *.opam files.
-p
--release
Dune sometimes changes these files.
$ wget https://github.com/ocaml/graphics/releases/download/5.1.2/graphics-5.1.2.tbz $ tar xf graphics-5.1.2.tbz $ cd graphics-5.1.2 $ git init && git add . && git commit -m "Initial commit" $ dune build -p graphics $ git diff diff --git a/graphics.opam b/graphics.opam index 0f53f1e..1386301 100644 --- a/graphics.opam +++ b/graphics.opam @@ -1,6 +1,6 @@ -version: "5.1.2" # This file is generated by dune, edit dune-project instead opam-version: "2.0" +version: "5.1.2" synopsis: "The OCaml graphics library" description: """ The graphics library provides a set of portable drawing @@ -38,4 +38,4 @@ build: [ "@doc" {with-doc} ] ] -dev-repo: "git+https://github.com/ocaml/graphics.git" \ No newline at end of file +dev-repo: "git+https://github.com/ocaml/graphics.git"
Note that I took graphics as an example, but it happens in many other packages.
dune
dune --version
n/a
ocaml
ocamlc --version
This was discovered by Debian QA, which checks that sources are not modified during build. Debian bug.
This problem is not fixed with 3.11.x, actually. The original repro case still applies.
Expected Behavior
In "reproducible release mode" (
-p
or--release
), Dune should not change *.opam files.Actual Behavior
Dune sometimes changes these files.
Reproduction
Note that I took graphics as an example, but it happens in many other packages.
Specifications
dune
(output ofdune --version
): 3.9.1 (dune --version
actually returnsn/a
)ocaml
(output ofocamlc --version
): 4.13.1Context
This was discovered by Debian QA, which checks that sources are not modified during build. Debian bug.